fix the column merging during graph traversal and concat selector #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
reviewed
Jun 29, 2023
tests/unit/dag/test_graph.py
Outdated
| @@ -95,3 +98,42 @@ def test_subgraph_with_summed_subgraphs(): | |||
| assert post_len == pre_len | |||
| assert iter_len == post_len | |||
| assert iter_len == pre_len | |||
|
|
|||
|
|
|||
| def test_selector_concat_parents(): | |||
There was a problem hiding this comment.
It looks like this tests that an overlapping column name prefers the version from the right-hand side. Not quite sure how to distill that into a good test name though...test_concat_prefers_rhs?
karlhigley
approved these changes
Jun 29, 2023
Documentation preview |
|
It looks like this change breaks a few tests in NVTabular that probably actually are related to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes graph traversal column merging. This is to allow for retreival of root columns and support overlapping column usage. The new behavior is to return whatever the last node of the graph is requiring for a target column. We also fixed the concat column op selector computation logic. Parents + dependencies were overriding input schema columns unnecessarily. That is only required when propagating column groups.