Skip to content

Commit

Permalink
move horovod to separte tox testenv
Browse files Browse the repository at this point in the history
  • Loading branch information
edknv committed Nov 4, 2022
1 parent 2a56d07 commit a58ce44
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 3 deletions.
5 changes: 5 additions & 0 deletions ci/test_unit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@
set -e

tox -e test-gpu $@

# skip multi-gpu testing if any arguments are supplied.
if [[ $# -eq 0 ]] ; then
tox -e test-multi-gpu
fi
25 changes: 22 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,28 @@ commands =
pip install -e .[all]

[testenv:test-gpu]
passenv = *
passenv =
WANDB_API_KEY
sitepackages = true
; Runs in: Internal Jenkins
; Runs GPU-based tests.
; The jenkins jobs run on an image based on merlin-hugectr. This will include all cudf configuration
; and other gpu-specific libraries that we can enxpect will always exist. Thus, we don't need
; to install requirements.txt yet. As we get better at python environment isolation, we will
; need to add some back.
deps =
-rrequirements/dev.txt
tensorflow<2.10
setenv =
TF_GPU_ALLOCATOR=cuda_malloc_async
commands =
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/nvtabular.git
python -m pytest --cov-report term --cov merlin -rxs {posargs:tests/unit}

[testenv:test-multi-gpu]
passenv =
OPAL_PREFIX
sitepackages = true
; Runs in: Internal Jenkins
; Runs GPU-based tests.
Expand All @@ -23,11 +44,9 @@ deps =
tensorflow<2.10
setenv =
TF_GPU_ALLOCATOR=cuda_malloc_async
HOROVOD_GPU_OPERATIONS=NCCL
allowlist_externals =
horovodrun
commands =
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/nvtabular.git
python -m pytest --cov-report term --cov merlin -rxs {posargs:tests/unit}
horovodrun -np 2 sh examples/usecases/multi-gpu/hvd_wrapper.sh python -m pytest -m horovod -rxs tests/unit

0 comments on commit a58ce44

Please sign in to comment.