Save and load LightFM model and schemas #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
edknv
commented
Feb 28, 2023
| @@ -26,7 +25,6 @@ | |||
|
|
|||
| def save_merlin_metadata( | |||
| export_path: Union[str, os.PathLike], | |||
| model: MerlinModel, | |||
There was a problem hiding this comment.
Removed because it looks like model is not used at all.
marcromeyn
approved these changes
Feb 28, 2023
|
|
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses NVIDIA-Merlin/Merlin#825.
Goals ⚽
Enable LightFM to save and load the model and schemas.
Implementation Details 🚧
save()that saves the LightFM object as a pickle. It also outputs input and output schemas along with the model.load()that can load the saved model and schema back into memory.Testing Details 🔍
Added unit tests to
tests/unit/lightfm/test_lightfm.py.