Convert Tensor to RaggedTensor in PrepareFeatures for list features #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes error about concatenation of features with different dimensions following change in dataloader for list columns of fixed size NVIDIA-Merlin/dataloader#112
The current implementation (of the EmbeddingTable layer for example) relies on an assumption that all list features (whether ragged or not) are passed through as ragged tensors. In the case of the
EmbeddingTablethis is for thecombiner="mean"to work which is passed to thetf.nn.safe_embedding_lookup_sparsefunction to take the average of the embeddings of list features by default.