Add Transformers4Rec repo test #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
nv-alaiacano
approved these changes
Apr 5, 2023
tox.ini
Outdated
| passenv=GIT_COMMIT | ||
| allowlist_externals = git | ||
| commands = | ||
| ; the GIT_COMMIT env is the current commit of the core repo |
There was a problem hiding this comment.
It should be the current commit of models repo.
.github/workflows/cpu-t4r.yml
Outdated
| branch=main | ||
| if [[ $ref_type == "tag"* ]] | ||
| then | ||
| git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/release*:refs/remotes/origin/release* |
There was a problem hiding this comment.
Could you leave a comment about what is happening here?
There was a problem hiding this comment.
I think this is just standard boilerplate for fetching a shallow copy of minimal size
There was a problem hiding this comment.
This can be replaced with something like this now. Moved this into a reusable action in our .github repo.
- name: Get Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@main
- name: Run tests
run: |
branch="${{ steps.get-branch-name.outputs.branch }}"
GIT_COMMIT=`git rev-parse HEAD` tox -e tox -e py38-transformers4rec-cpu -- $branchNote that this doesn't currently work with our self-hosted runners because the action is implemented with docker and we can't run docker in our self-hosted runners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Github actions that run the unit tests in
transformers4rec. The motivation for adding these tests is to detect if changes in Dataloader could potentially break T4Rec since T4Rec now depends on Models. These downstream repo tests are similar to how they are set up in Core.