Adding ParallelBlock #1088
Merged
Adding ParallelBlock #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
This was referenced May 15, 2023
Merged
Merged
Merged
Merged
marcromeyn
force-pushed
the
torch/parallel-block
branch
from
77ca69b to
8ce54d1
Compare
edknv
reviewed
May 17, 2023
edknv
approved these changes
May 19, 2023
26 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Adding
ParallelBlock.Implementation Details 🚧
The definition of this block is slightly different than we are used to in TF. In this implementation each branch is of type
BlockContainer, this makes it easier to append/prepend to it.Testing Details 🔍
Since it's a low-level class, I maximized the test-coverage
