Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tf.keras.optimizers.Adagrad() to tf.keras.optimizers.legacy.Adagrad() #1098

Merged
merged 2 commits into from
May 16, 2023

Conversation

rnyak
Copy link
Contributor

@rnyak rnyak commented May 16, 2023

Fixes # (issue)

Goals ⚽

Currently training speed ~2x slower if we use tf.keras.optimizers.Adagrad(). This PR changes that optimizer to tf.keras.optimizers.legacy.Adagrad() to avoid such training speed issue.

Implementation Details 🚧

Testing Details 🔍

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rnyak rnyak requested a review from bschifferer May 16, 2023 20:51
@rnyak rnyak added this to the Merlin 23.05 milestone May 16, 2023
@rnyak rnyak added the P0 label May 16, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1098

@edknv edknv merged commit 8bb655b into main May 16, 2023
@edknv edknv deleted the legacy_optimizer branch May 16, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants