Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reloading of the transformer-based models #1147

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix reloading of the transformer-based models #1147

merged 1 commit into from
Jun 13, 2023

Conversation

sararb
Copy link
Contributor

@sararb sararb commented Jun 13, 2023

Fixes #1132

Goals ⚽

  • Import transformers assets when the Hugging Face library is installed.

Implementation Details 🚧

  • Add import transformers in the init file of Merlin Models

Testing Details 🔍

  • The issue is happening when we try to reload a model in a different python process to the one that saved the model.

@sararb sararb self-assigned this Jun 13, 2023
@sararb sararb added the bug Something isn't working label Jun 13, 2023
@sararb sararb added this to the Merlin 23.06 milestone Jun 13, 2023
@sararb sararb requested a review from rnyak June 13, 2023 09:35
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1147

@edknv edknv merged commit 6ea8828 into main Jun 13, 2023
@edknv edknv deleted the fix-transformers-import branch June 13, 2023 12:12
@rnyak rnyak mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

@rnyak rnyak Awaiting requested review from rnyak

Assignees

@sararb sararb

Labels
bug Something isn't working
Projects
None yet
Milestone
Merlin 23.06
Development

Successfully merging this pull request may close these issues.

[BUG] Getting error when loading back a saved session-based model
2 participants
@sararb @edknv