Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sok import error in ut #1231

Closed
wants to merge 1 commit into from
Closed

Fix sok import error in ut #1231

wants to merge 1 commit into from

Conversation

EmmaQiaoCh
Copy link
Contributor

SOK has refactored the code path and remove experiment. There are ut failure in tests/unit/tf/horovod/test_embedding.py due to below error:
ImportError: 'horovod' and 'sparse_operation_kit' are required to use SOKEmbedding.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 17, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@EmmaQiaoCh EmmaQiaoCh closed this Dec 17, 2023
@EmmaQiaoCh EmmaQiaoCh reopened this Dec 17, 2023
@EmmaQiaoCh EmmaQiaoCh self-assigned this Dec 17, 2023
@EmmaQiaoCh EmmaQiaoCh added 23.12 enhancement New feature or request labels Dec 17, 2023
@EmmaQiaoCh EmmaQiaoCh requested a review from minseokl December 17, 2023 07:00
@EmmaQiaoCh
Copy link
Contributor Author

/ok to test

@edknv
Copy link
Contributor

edknv commented Jan 7, 2024

Duplicate: #1232.

@edknv edknv closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minseokl minseokl Awaiting requested review from minseokl

Assignees

@EmmaQiaoCh EmmaQiaoCh

Labels
23.12 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmaQiaoCh @edknv