Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and load SOK model embeddings #951

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

WonderingWJ
Copy link
Contributor

@WonderingWJ WonderingWJ commented Jan 17, 2023

Fixes # (issue)

Goals ⚽

Provide an interfact for SOKEmbedding load/dump and a sample code for SOKEmbedding model load/dump

Implementation Details 🚧

Testing Details πŸ”

This ticket is about saving and loading a model trained with SOK. this might take 1 or two releases.

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-951

@rnyak rnyak added this to the Merlin 23.02 milestone Jan 18, 2023
@rnyak rnyak requested review from edknv and marcromeyn January 18, 2023 15:51
@rnyak
Copy link
Contributor

rnyak commented Jan 18, 2023

related PR: #863

@rnyak rnyak modified the milestones: Merlin 23.02, Merlin 23.03 Feb 13, 2023
@rnyak
Copy link
Contributor

rnyak commented Feb 13, 2023

@WonderingWJ is this the duplicate of #863? shall we remove this one or keep both, bcs both are required? could you please provide some info? thanks.

@WonderingWJ
Copy link
Contributor Author

@rnyak This one is not a duplication of #863. This one targets to solve the load/dump for SOK. That one is to integrate SOK into merlin models

@rnyak
Copy link
Contributor

rnyak commented Feb 22, 2023

@WonderingWJ is this still WIP or this is ready? could you update your branch? thanks.

@rnyak
Copy link
Contributor

rnyak commented Mar 8, 2023

@WonderingWJ any update on that PR? can we close it?

@edknv
Copy link
Contributor

edknv commented Mar 21, 2023

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

@WonderingWJ
Copy link
Contributor Author

@WonderingWJ Is this PR still relevant? If so, we will need to rebase this PR.

The dump/load method of SOK is under development. After SOK load/dump is done, we can discuss this MR. Currently, we don't need to rebase. Thank you!

@WonderingWJ
Copy link
Contributor Author

@WonderingWJ any update on that PR? can we close it?

Sorry for late response. The SOK load/dump is under development. Currently, we can keep this MR and discuss it after SOK load/dump is done.

@rnyak rnyak modified the milestones: Merlin 23.03, Merlin 23.04 Mar 27, 2023
@karlhigley karlhigley changed the title Fea sok load dump Save and load SOK model embeddings May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants