Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancing the next-item prediction notebook documentation #975

Merged

Conversation

MarkMoTrin
Copy link
Contributor

Fixes # (issue)

Goals ⚽

Made changes based on Ronay's suggestions. Removed all extra cells, nvidia-smi, and pwd references.

Implementation Details 🚧

Testing Details πŸ”

Changes 

- Added tf unlock of memory to beginning of imports
- notebook adds links to each method used throughout the notebook to help new users to navigate the library.
@review-notebook-app
Copy link

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rnyak rnyak added chore Maintenance for the repository examples labels Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-975

@@ -39,6 +39,8 @@
"\n",
Copy link
Contributor

@rnyak rnyak Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #20.    get_booking(input_data_folder)

Please do not change this cell and do not assign path to input_data_folder bcs the test is failing. you dont need to change here. Please use the original script.


Reply via ReviewNB

@MarkMoTrin MarkMoTrin changed the title Ronay suggestions updated enhancing the nex-item prediction notebook documentation Feb 8, 2023
@MarkMoTrin MarkMoTrin changed the title enhancing the nex-item prediction notebook documentation enhancing the next-item prediction notebook documentation Feb 8, 2023
@rnyak rnyak merged commit 12763ca into NVIDIA-Merlin:main Feb 14, 2023
sararb pushed a commit that referenced this pull request Feb 14, 2023
* Add files via upload

Changes 

- Added tf unlock of memory to beginning of imports
- notebook adds links to each method used throughout the notebook to help new users to navigate the library.

* Updated Ronay suggestions

* Used original data loading code

---------

Co-authored-by: rnyak <ronayak@hotmail.com>
sararb pushed a commit that referenced this pull request Feb 28, 2023
* Add files via upload

Changes 

- Added tf unlock of memory to beginning of imports
- notebook adds links to each method used throughout the notebook to help new users to navigate the library.

* Updated Ronay suggestions

* Used original data loading code

---------

Co-authored-by: rnyak <ronayak@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants