Renaming ProcessList to PrepareFeatures #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed size first dim in graph mode and not being compatible with the ragged sequential features
… with last dim undefined (which happens in graph mode)
… only list features but also scalar features
Documentation preview |
oliverholworthy
approved these changes
Feb 17, 2023
37 tasks
edknv
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Fixed error that was causing the broadcasted context feature to have fixed size first dim in graph mode and not being compatible with the ragged sequential features * Enforcing non-list (scalar) features to be 2D (batch size,1) if 1D or with last dim undefined (which happens in graph mode) * Making Continuous support_masking=True (to cascade mask) * Changing BroadcastToSequence to fix some issues and simplify the masking * Fixed tests * Fixed test * Renaming ProcessList to PrepareFeatures, as it nows also prepares not only list features but also scalar features * Fixed tests
sararb
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Fixed error that was causing the broadcasted context feature to have fixed size first dim in graph mode and not being compatible with the ragged sequential features * Enforcing non-list (scalar) features to be 2D (batch size,1) if 1D or with last dim undefined (which happens in graph mode) * Making Continuous support_masking=True (to cascade mask) * Changing BroadcastToSequence to fix some issues and simplify the masking * Fixed tests * Fixed test * Renaming ProcessList to PrepareFeatures, as it nows also prepares not only list features but also scalar features * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR renames
ProcessListtoPrepareFeatures, so that it is more generic as it currently prepares not only list features but also scalar features.Implementation Details 🚧
Testing Details 🔍
sample_batch()now has aprepare_featuresarg as a replacement forprocess_listsample_batch(..., prepare_features=True)to avoid callingListToRagged()directly