Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken PoC notebook due mismatching output names between config file and saved ranking model #112

Closed
wants to merge 1 commit into from
Closed

Fix broken PoC notebook due mismatching output names between config file and saved ranking model #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions merlin/systems/dag/ops/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def __init__(self, model_or_path, custom_objects: dict = None):
outputs = list(default_signature.structured_outputs.values())

input_col_names = [col.name.split("/")[0] for col in inputs]
output_col_names = [col.name.split("/")[0] for col in outputs]
output_col_names = [col.name for col in outputs]

self.input_schema = Schema()
for col, input_col in zip(input_col_names, inputs):
Expand Down Expand Up @@ -173,7 +173,7 @@ def _export_model(self, model, name, output_path, version=1):
# this assumes the list columns are 1D tensors both for cats and conts
config.output.append(
model_config.ModelOutput(
name=col.name.split("/")[0],
name=col.name,
data_type=_convert_dtype(col.dtype),
dims=[-1, col.shape[1]],
)
Expand Down