Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Merlin e2e example #117

Merged
merged 9 commits into from
Jun 9, 2022
Merged

Fixes Merlin e2e example #117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b85d25
fix output names
rnyak Jun 2, 2022
0f9fa18
fixes to ensure use of correct keys from tf models
jperez999 Jun 9, 2022
a25c7e9
Merge branch 'main' into fix_model_outputnames
jperez999 Jun 9, 2022
361c9d4
clean up code
jperez999 Jun 9, 2022
38367f4
Merge branch 'fix_model_outputnames' of https://github.com/jperez999/…
jperez999 Jun 9, 2022
7331d72
Merge branch 'main' into fix_model_outputnames
benfred Jun 9, 2022
b15b745
scrubbing nvt backend until fixed
jperez999 Jun 9, 2022
1e1226f
Merge branch 'fix_model_outputnames' of https://github.com/jperez999/…
jperez999 Jun 9, 2022
604d049
revert backend change
jperez999 Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion merlin/systems/dag/ops/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def export(self, path, input_schema, output_schema, node_id=None, version=1):
modified_workflow,
node_name,
node_export_path,
backend="python",
backend="nvtabular",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work on the containers? I saw this PR go through, and I'm wondering if the NVT backend is still available https://github.com/NVIDIA-Merlin/Merlin/pull/378/files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats why I need the other PR in merlin to go through also... need to recook

sparse_max=self.sparse_max,
max_batch_size=self.max_batch_size,
cats=self.cats,
Expand Down
2 changes: 1 addition & 1 deletion merlin/systems/triton/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def export_tensorflow_ensemble(
label_columns=None,
sparse_max=None,
version=1,
nvtabular_backend="python",
nvtabular_backend="nvtabular",
cats=None,
conts=None,
):
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/systems/test_inference_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ def test_workflow_op_exports_own_config(tmpdir, dataset, engine):

# The config file contents are correct
assert parsed.name == triton_op.export_name
assert parsed.backend == "python"
assert parsed.backend == "nvtabular"