Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor systems to handle shape in columns #278

Closed
wants to merge 3 commits into from

Conversation

jperez999
Copy link
Collaborator

@jperez999 jperez999 commented Jan 24, 2023

This PR adds in support for shape in column schemas. It removes the use of optional arguments is_list and is_ragged. Now those arguments are used in the properties dictionary to be consumed by the column schema.

Depends on NVIDIA-Merlin/core#195

@jperez999 jperez999 requested a review from karlhigley January 24, 2023 21:03
@jperez999 jperez999 self-assigned this Jan 24, 2023
@jperez999 jperez999 added clean up chore Maintenance for the repository labels Jan 24, 2023
@jperez999 jperez999 added this to the Merlin 23.01 milestone Jan 24, 2023
@karlhigley karlhigley modified the milestones: Merlin 23.01, Merlin 23.02 Jan 24, 2023
@jperez999 jperez999 linked an issue Jan 30, 2023 that may be closed by this pull request
@karlhigley
Copy link
Contributor

Superseded by subsequent work on schema shapes and TensorTable

@karlhigley karlhigley closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add list column support in Merlin Systems
3 participants