-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Runtimes
and Executors
to serve NVT Workflow
s
#320
Closed
karlhigley
wants to merge
17
commits into
NVIDIA-Merlin:main
from
karlhigley:refactor/runtimes-executors
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
05c12b9
Condense the `WorkflowRunner` sub-classes
karlhigley 3748436
Remove `HugeCTRWorkflowRunner`
karlhigley b22471c
Inline `_transform_outputs` hook method
karlhigley 3ea2846
Merge branch 'main' into refactor/workflow-runners
karlhigley 05130f1
Remove stray code that got pasted into docstring
karlhigley 1b5ad13
Use `Runtimes` and `Executors` to serve NVT `Workflow`s
karlhigley 9789068
Get rid of `WorkflowRunner` entirely by collapsing into Triton model
karlhigley 47c6751
Create and apply `OpTable` class for runtimes
karlhigley 5027dd6
Rework `NVTabularServingExecutor` to be structured similarly to base
karlhigley bbbbea7
Rework `NVTabularServingExecutor` to align with `LocalExecutor`
karlhigley 8fceca3
Merge branch 'main' into refactor/runtimes-executors
karlhigley 4cdfacf
Fix check for empty `OpTable` instances without registered ops
karlhigley 5261b4c
Update `Runtime` docstring to refer to Merlin DAGs (not Systems graphs)
karlhigley 671d7b9
Merge branch 'main' into refactor/runtimes-executors
karlhigley b88260a
Merge branch 'main' into refactor/runtimes-executors
karlhigley 89e211f
Port fix to conversions to check for presence of `cudf`
karlhigley 549f6af
Merge remote-tracking branch 'origin/refactor/runtimes-executors' int…
karlhigley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# | ||
# Copyright (c) 2023, NVIDIA CORPORATION. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the scenario where we'd want to pass
convert=False
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The split between
convert
andtransform
allows you to do the conversion ahead of time manually and then passconvert=False
in order to avoid doing it every time the transform runs as a small optimization. We put this in so that it was possible to maintain the previous behavior where the conversion only happens once, while also offering the convenience of doing it automatically in the cases where you're not worried about the perf implications.