Subgraph support changes for multistage example #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperez999
added
enhancement
karlhigley
approved these changes
Jun 22, 2023
merlin/systems/dag/ops/feast.py
Outdated
| return ( | ||
| DataFormats.NUMPY_TENSOR_TABLE | ||
| | DataFormats.CUPY_TENSOR_TABLE | ||
| ) |
There was a problem hiding this comment.
Is this not the default for ops in Systems? I see that some ops are flagged as only supporting tensor tables and some as only supporting data frames. Is the default support for all of those?
There was a problem hiding this comment.
No we never set it as the default in the inference operator https://github.com/NVIDIA-Merlin/systems/blob/main/merlin/systems/dag/ops/operator.py
karlhigley
changed the title
Documentation preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added supported format flags for specific operators that may require specific data types internally. Added the capability to load artifacts in a local runtime, was only used previously for triton runtimes after export. Migrated artifact load and save to core NVIDIA-Merlin/core#349. Removed hasattr checks in triton python model class because all operators now have artifact hooks.