Skip to content

(chore) Update NeMo FW docs and tutorials #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

(chore) Update NeMo FW docs and tutorials #208

wants to merge 21 commits into from
+947 −134

Conversation

marta-sd
Copy link
Contributor

No description provided.

@marta-sd marta-sd requested review from a team as code owners September 22, 2025 12:59
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 22, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@marta-sd
update nemo-run example
a8edcbd 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
add nemo fw docs back (not updated yet)
915b1a9 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
remove copy of documentation.md
63829be 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
remove redundant adapters docs
99113ec 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update all the links
01c43b7 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
add check_health and check_endpoint utilities functions
296f67c 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update evaluation-doc
e094f22 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update snippets
6fc12f8 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update evaluation-hf.md
b2cb3f9 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update evaluation-with-ray.md
651fa35 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
update notebooks
8cf0f77 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
athitten
athitten reviewed Sep 23, 2025
View reviewed changes
athitten
athitten reviewed Sep 23, 2025
View reviewed changes
@marta-sd
add output_dir in examples
d47a5d7 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
athitten
athitten reviewed Sep 24, 2025
View reviewed changes
athitten
athitten reviewed Sep 24, 2025
View reviewed changes
@athitten
Copy link
Contributor

Thank you so much @marta-sd LGTM, couple of minor comments. Liked the new nemo-run eval script, quite neat!

@marta-sd
update vllm installation instructions
78b84b2 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
fix script path
0e2e274 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
@marta-sd
fix deploy.sh snippet (remove extra spaces)
1e7f7a7 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
athitten
athitten previously approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@athitten athitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
@jgerh jgerh self-requested a review September 25, 2025 19:48
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
athitten
athitten reviewed Sep 25, 2025
View reviewed changes
@marta-sd @athitten
Update scripts/evaluation_with_nemo_run.py
cde7402 
Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com>
Signed-off-by: Marta Stepniewska-Dziubinska <marta-sd@users.noreply.github.com>
marta-sd and others added 4 commits September 26, 2025 08:51
@marta-sd @athitten
Update scripts/evaluation_with_nemo_run.py
5fc491f 
Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com>
Signed-off-by: Marta Stepniewska-Dziubinska <marta-sd@users.noreply.github.com>
@marta-sd @athitten
Update scripts/evaluation_with_nemo_run.py
559b05a 
Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com>
Signed-off-by: Marta Stepniewska-Dziubinska <marta-sd@users.noreply.github.com>
@marta-sd @athitten
Apply suggestions from code review
722ac0a 
Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com>
Signed-off-by: Marta Stepniewska-Dziubinska <marta-sd@users.noreply.github.com>
@marta-sd
revert flag rename for triton
7455112 
Signed-off-by: Marta Stepniewska-Dziubinska <martas@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athitten athitten athitten left review comments

@jgerh jgerh Awaiting requested review from jgerh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marta-sd @athitten @lbliii