feat(tests): add tests for models and options and api #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgasser-nv
requested changes
Apr 18, 2025
Collaborator
tgasser-nv
left a comment
tgasser-nv
left a comment
There was a problem hiding this comment.
Looks good! I think we need tests against the NeMoLLM, TaskPrompt, and FiddlerGuardrails BaseModel-inherited classes too. Could you add one valid and one invalid per model, to check the validation is working correctly?
Collaborator
Author
|
Thank you @tgasser-nv for the review. NeMoLLM is deprecated (just did the rebase so that it is clear), FiddlerGuardrails is not affected by the migration PR and is a community integration. I've opened a separate PR (#1132) for TaskPrompt as I had to implement some fixes. |
Pouyanpi
force-pushed
the
test/add-missing-tests
branch
from
fce48ef to
a7e3fa4
Compare
tgasser-nv
approved these changes
Apr 22, 2025
Collaborator
tgasser-nv
left a comment
tgasser-nv
left a comment
There was a problem hiding this comment.
LGTM, just a typo nit and please merge :-)
- Add test for multiple interactions with same policy - Add test for multiple policies in single interaction - Add test for duplicate policy IDs (currently allowed) - Document missing validations for future improvement
Pouyanpi
force-pushed
the
test/add-missing-tests
branch
from
89f0597 to
f191dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more tests that might help reviewing #967