Skip to content

Conversation

trend-willem-gooderham
Copy link
Contributor

@trend-willem-gooderham trend-willem-gooderham commented Aug 26, 2025

Description

Adds a new community integration, Trend Micro Vision One AI Application Security, to NeMo Guardrails.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

Copy link
Contributor

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1355

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (92fe37c) to head (92c444f).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
nemoguardrails/library/trend_micro/actions.py 94.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1355      +/-   ##
===========================================
+ Coverage    71.62%   71.74%   +0.11%     
===========================================
  Files          171      172       +1     
  Lines        17021    17079      +58     
===========================================
+ Hits         12192    12254      +62     
+ Misses        4829     4825       -4     
Flag Coverage Δ
python 71.74% <95.31%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/rails/llm/config.py 90.92% <100.00%> (+0.17%) ⬆️
nemoguardrails/library/trend_micro/actions.py 94.33% <94.33%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pouyanpi Pouyanpi added this to the v0.17.0 milestone Sep 2, 2025
@Pouyanpi Pouyanpi added the enhancement New feature or request label Sep 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new community integration for Trend Micro Vision One AI Application Security to NeMo Guardrails, providing AI Guard functionality for input and output flow protection.

Key changes:

  • Implements Trend Micro AI Guard integration with support for both Colang v1 and v2
  • Adds comprehensive test coverage for various scenarios including blocking, errors, and missing configuration
  • Provides example configurations and documentation for the new integration

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
nemoguardrails/library/trend_micro/actions.py Core action implementation for Trend Micro AI Guard API integration
nemoguardrails/library/trend_micro/flows.v1.co Colang v1 flow definitions for input and output rails
nemoguardrails/library/trend_micro/flows.co Colang v2 flow definitions for input and output rails
tests/test_trend_ai_guard.py Comprehensive test suite covering blocked responses, errors, and edge cases
examples/configs/trend_micro/ Example configuration for Colang v1 implementation
examples/configs/trend_micro_v2/ Example configuration for Colang v2 implementation
docs/user-guides/community/trend-micro.md User documentation with setup instructions and examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit in the actions, some docs changes are desirable. It would be good to change the env var names at an absolute minimum but ideally, we should pull them through the config.

Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com>
Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
@trend-willem-gooderham trend-willem-gooderham force-pushed the feature/trend-ai-guard branch 2 times, most recently from 49f1dcf to 64ae034 Compare September 4, 2025 18:28
Switched to use colang config for endpoint and api key env var

Added onboarding steps from Trend's side
Expanded on documentation and examples
@trend-willem-gooderham
Copy link
Contributor Author

Thanks for your review @erickgalinkin, I followed up/addressed all of your comments.

Added aditional doc strings, redefined flows
modified how failures are handled added output_mapping
@trend-willem-gooderham
Copy link
Contributor Author

Thank you for your review @Pouyanpi I believe I have addressed all of your comments

Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trend-willem-gooderham for making the changes 👍🏻 It looks good to me.

@trend-willem-gooderham
Copy link
Contributor Author

Hello @erickgalinkin, Could I get another review? Hoping to get this PR merged soon.

Thanks

Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tgasser-nv tgasser-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @erickgalinkin and @Pouyanpi for the discussion and iterations

@trend-willem-gooderham
Copy link
Contributor Author

Hello @tgasser-nv and @Pouyanpi

I don't have permission to merge, so please merge this PR when you can.
Thanks again for all of the reviews

@Pouyanpi Pouyanpi merged commit 028b442 into NVIDIA-NeMo:develop Sep 22, 2025
20 checks passed
tgasser-nv pushed a commit that referenced this pull request Sep 22, 2025
…tegration (#1355)

---------

Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com>
Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
tgasser-nv pushed a commit that referenced this pull request Sep 22, 2025
…tegration (#1355)

---------

Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com>
Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants