-
Notifications
You must be signed in to change notification settings - Fork 546
feat: Add Trend Micro Vision One AI Application Security community integration #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Trend Micro Vision One AI Application Security community integration #1355
Conversation
Documentation preview |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1355 +/- ##
===========================================
+ Coverage 71.62% 71.74% +0.11%
===========================================
Files 171 172 +1
Lines 17021 17079 +58
===========================================
+ Hits 12192 12254 +62
+ Misses 4829 4825 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new community integration for Trend Micro Vision One AI Application Security to NeMo Guardrails, providing AI Guard functionality for input and output flow protection.
Key changes:
- Implements Trend Micro AI Guard integration with support for both Colang v1 and v2
- Adds comprehensive test coverage for various scenarios including blocking, errors, and missing configuration
- Provides example configurations and documentation for the new integration
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
nemoguardrails/library/trend_micro/actions.py | Core action implementation for Trend Micro AI Guard API integration |
nemoguardrails/library/trend_micro/flows.v1.co | Colang v1 flow definitions for input and output rails |
nemoguardrails/library/trend_micro/flows.co | Colang v2 flow definitions for input and output rails |
tests/test_trend_ai_guard.py | Comprehensive test suite covering blocked responses, errors, and edge cases |
examples/configs/trend_micro/ | Example configuration for Colang v1 implementation |
examples/configs/trend_micro_v2/ | Example configuration for Colang v2 implementation |
docs/user-guides/community/trend-micro.md | User documentation with setup instructions and examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
866255d
to
371812f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit in the actions, some docs changes are desirable. It would be good to change the env var names at an absolute minimum but ideally, we should pull them through the config.
Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com> Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
49f1dcf
to
64ae034
Compare
Switched to use colang config for endpoint and api key env var Added onboarding steps from Trend's side Expanded on documentation and examples
64ae034
to
3412335
Compare
Thanks for your review @erickgalinkin, I followed up/addressed all of your comments. |
Added aditional doc strings, redefined flows modified how failures are handled added output_mapping
a901ec4
to
92c444f
Compare
Thank you for your review @Pouyanpi I believe I have addressed all of your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trend-willem-gooderham for making the changes 👍🏻 It looks good to me.
Hello @erickgalinkin, Could I get another review? Hoping to get this PR merged soon. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @erickgalinkin and @Pouyanpi for the discussion and iterations
Hello @tgasser-nv and @Pouyanpi I don't have permission to merge, so please merge this PR when you can. |
…tegration (#1355) --------- Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com> Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
…tegration (#1355) --------- Co-authored-by: Trent Holmes <trent_holmes@trendmicro.com> Co-authored-by: Karanjot Singh Saggu <karanjotsingh_saggu@trendmicro.com>
Description
Adds a new community integration, Trend Micro Vision One AI Application Security, to NeMo Guardrails.
Related Issue(s)
Checklist