docs(tracing): Update tracing notebooks with VDR feedback #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1376 +/- ##
========================================
Coverage 71.62% 71.62%
========================================
Files 171 171
Lines 17021 17021
========================================
Hits 12192 12192
Misses 4829 4829
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pouyanpi
approved these changes
Sep 5, 2025
There was a problem hiding this comment.
Thank you Tim, it looks good 👍🏻
Regarding the reqs installation command:
pip install nemoguardrails
would it be better to use nemoguardrails >= 0.16.0 ?
something we must tell VDR to be aware of if they are going to re-run the notebooks as we have not released it yet.
Also something very minor:
in 2_tracing_with_jaeger.ipynb notebook I see in cell 10:
CONFIG_MODELS: Dict[str, str] but should be List[Dict[str, str]]
cparisien
approved these changes
Sep 5, 2025
tgasser-nv
added a commit
that referenced
this pull request
Sep 22, 2025
* Updated notebook 1 with VDR feedback * Updated notebook 2 (Jaeger) with VDR comments * Replace Llama 3.1 8B with Llama 4 scout as main model * Correct type in cell 10 notebook 2
tgasser-nv
added a commit
that referenced
this pull request
Sep 22, 2025
* Updated notebook 1 with VDR feedback * Updated notebook 2 (Jaeger) with VDR comments * Replace Llama 3.1 8B with Llama 4 scout as main model * Correct type in cell 10 notebook 2
Pouyanpi
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Updated notebook 1 with VDR feedback * Updated notebook 2 (Jaeger) with VDR comments * Replace Llama 3.1 8B with Llama 4 scout as main model * Correct type in cell 10 notebook 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist