fix(logging): correct message type formatting in logs #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pouyanpi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tgasser-nv
approved these changes
Sep 25, 2025
Collaborator
tgasser-nv
left a comment
tgasser-nv
left a comment
There was a problem hiding this comment.
Looks good, the dict lookup is cleaner than the nested if .. else
Pouyanpi
force-pushed
the
fix/logging-callbacks
branch
from
7c61e40 to
02c5674
Compare
Pouyanpi
added a commit
that referenced
this pull request
Sep 26, 2025
* refactor(logging): replace if-else with dict for type mapping
Pouyanpi
added a commit
that referenced
this pull request
Oct 1, 2025
* refactor(logging): replace if-else with dict for type mapping
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(logging): replace if-else with dict for type mapping
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(logging): replace if-else with dict for type mapping
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(logging): replace if-else with dict for type mapping
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 28, 2025
* refactor(logging): replace if-else with dict for type mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
correct message type formatting in logs