-
Couldn't load subscription status.
- Fork 552
feat(logging): improve event logging and add bot thinking display #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small comments.
BEFORE MERGING: Could you run a local integration test with all the reasoning-models we claim to support? Copy-and-paste the output into the description as a test-plan. We need to check this new approach works with production models
8ae50ef to
98c8911
Compare
341297f to
ead6ff7
Compare
ead6ff7 to
bc47bea
Compare
#1434) add BotThinking event support
#1434) add BotThinking event support
#1434) add BotThinking event support
#1434) add BotThinking event support
Stack Info
This PR is part of a stack:
#1427 → #1431 → #1432
Description
Enhanced event logging in the runtime and callbacks to better display bot thinking events with reasoning traces. Moved event logging to occur after event generation for proper ordering, added reasoning content extraction from LLM completions, and improved console output formatting for different event types.
Changes