test: fix flaky stats logging interval timing test #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace real time.sleep() calls with mocked time.time() to eliminate timing dependencies that caused intermittent CI failures. The test would occasionally fail when execution overhead pushed total elapsed time over the 1.0 second threshold, triggering unexpected stats logging. Mocking time.time() ensures deterministic behavior across all environments and reduces test execution time from ~1.16s to ~0.02s.
Pouyanpi
changed the title
Pouyanpi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
tgasser-nv
approved these changes
Oct 20, 2025
Pouyanpi
added a commit
that referenced
this pull request
Oct 28, 2025
Replace real time.sleep() calls with mocked time.time() to eliminate timing dependencies that caused intermittent CI failures. The test would occasionally fail when execution overhead pushed total elapsed time over the 1.0 second threshold, triggering unexpected stats logging. Mocking time.time() ensures deterministic behavior across all environments and reduces test execution time from ~1.16s to ~0.02s.
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 28, 2025
Replace real time.sleep() calls with mocked time.time() to eliminate timing dependencies that caused intermittent CI failures. The test would occasionally fail when execution overhead pushed total elapsed time over the 1.0 second threshold, triggering unexpected stats logging. Mocking time.time() ensures deterministic behavior across all environments and reduces test execution time from ~1.16s to ~0.02s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky test in
test_cache_lfu.pythat was intermittently failing on CI due to timing dependencies.Problem
The test relied on
time.sleep(0.05)with an assumption that 10 iterations would take < 1.0 seconds. On CI, execution overhead from cache operations and system load caused cumulative delays that would occasionally push total time over 1.0 seconds, triggering unexpected stats logging and causing the test to fail withAssertionError: 1 != 0.Solution
Mock
time.time()with controlled values that advance exactly 0.05 seconds per iteration, removing all timing dependencies.Changes
time.sleep()calls with mockedtime.time()intest_stats_logging_interval_timingBenefits
Test plan