feat: Refit: reduce the number of IPC calls by packing weights #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
4 tasks
yuki-97
reviewed
Jul 2, 2025
yuki-97
reviewed
Jul 2, 2025
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
yuki-97
added
CI:L0
|
seems there's a flaky unit test #610, I'll look it. |
yuki-97
added
CI:L0
|
Hi @guyueh1 , I think you have some numbers of the refit time w/ and w/o your PR, can you paste them in the PR? |
|
@yuki-666 a reference datapoint: deepseek-v3 refit, the total time for |
parthchadha
approved these changes
Jul 7, 2025
yuki-97
approved these changes
Jul 7, 2025
terrykong
approved these changes
Jul 7, 2025
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
…A-NeMo#589) Signed-off-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…A-NeMo#589) Signed-off-by: Guyue Huang <guyueh@nvidia.com> Co-authored-by: Parth Chadha <pchadha@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
In refit, reduce the number of IPC calls to once per bucket by packing weights.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information