DRAFT: Remove runtime type selection #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsaev
reviewed
Aug 1, 2022
|
Yes that's exactly correct - the current version is just hacked but it shows the desired outcome of having only compile time type selection. CMake flags like you suggested will be necessary. Thanks |
|
Do you think having C++ interface would make sense? |
|
If you mean generally for AmgX then, yes, I definitely do - we have been considering it for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing runtime selection of the supported types in AmgX makes the code more complex but doesn't seem to benefit users significantly from our discussions so far.
This is a draft pull request that will eventually remove all runtime type selection and instead allow users to choose type at compile time.