Make shared library, tests and examples optional #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the following good reasons: 0. All CMake projects are generally encouraged to support BUILD_SHARED_LIBS option, it is often found in the state-of-art opensource software 1. We want to link AMGX statically, in order to have only what we need in the application binary 2. AMGX shared library throws "relocation truncated to fit" errors upon linking in Debug mode
|
This looks good, thanks. Give me a short while to pass it through our tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make AMGX shared library (amgxsh) building optional for the following good reasons:
Furthermore, adding
AMGX_WITH_TESTSandAMGX_WITH_EXAMPLESoptions to disable examples and tests, e.g. for production builds.By default, the previous build behavior is preserved.