Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to build dali with gcc 14 due to missing cstdint header #5591

Closed
1 task done
hubutui opened this issue Aug 2, 2024 · 3 comments · Fixed by #5594
Closed
1 task done

fail to build dali with gcc 14 due to missing cstdint header #5591

hubutui opened this issue Aug 2, 2024 · 3 comments · Fixed by #5594
Assignees
Labels
bug Something isn't working

Comments

@hubutui
Copy link

hubutui commented Aug 2, 2024

Version

1.40.0

Describe the bug.

https://github.com/NVIDIA/DALI/blob/v1.40.0/dali/util/uri.h#L51 use uint32_t without including the cstdint header, this leads to compilation failure.

Minimum reproducible example

none

Relevant log output

In file included from /build/python-nvidia-dali/src/python-nvidia-dali/dali/pipeline/workspace/workspace.h:27,
                 from /build/python-nvidia-dali/src/python-nvidia-dali/dali/pipeline/workspace/sample_workspace.cc:15:
/build/python-nvidia-dali/src/python-nvidia-dali/dali/pipeline/data/tensor_list.h:87:34: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   87 |   DLL_PUBLIC TensorList<Backend>(TensorList<Backend> &&other) noexcept;
      |                                  ^~~~~~~~~~~~~~~~~~~
/build/python-nvidia-dali/src/python-nvidia-dali/dali/pipeline/data/tensor_list.h:87:34: note: remove the ‘< >’
[ 38%] Building CXX object dali/CMakeFiles/dali.dir/util/cufile.cc.o
In file included from /build/python-nvidia-dali/src/python-nvidia-dali/dali/util/uri.cc:15:
/build/python-nvidia-dali/src/python-nvidia-dali/dali/util/uri.h:51:8: error: use of enum ‘ParseOpts’ without previous declaration
   51 |   enum ParseOpts : uint32_t {
      |        ^~~~~~~~~
/build/python-nvidia-dali/src/python-nvidia-dali/dali/util/uri.h:51:20: error: ‘uint32_t’ was not declared in this scope
   51 |   enum ParseOpts : uint32_t {
      |                    ^~~~~~~~
/build/python-nvidia-dali/src/python-nvidia-dali/dali/util/uri.h:24:1: note: ‘uint32_t’ is defined in header ‘<cstdint>; this is probably fixable by adding ‘#include <cstdint>’
   23 | #include "dali/core/api_helper.h"
  +++ |+#include <cstdint>
   24 | 
/build/python-nvidia-dali/src/python-nvidia-dali/dali/util/uri.h:51:29: error: default member initializer for unnamed bit-field
   51 |   enum ParseOpts : uint32_t {
      |                             ^

Other/Misc.

quick fix, add one line to https://github.com/NVIDIA/DALI/blob/v1.40.0/dali/util/uri.h#L17

#include <cstdint>

Check for duplicates

  • I have searched the open bugs/issues and have found no duplicates for this bug report
@hubutui hubutui added the bug Something isn't working label Aug 2, 2024
hubutui added a commit to archlinuxcn/repo that referenced this issue Aug 2, 2024
@mdabek-nvidia
Copy link
Collaborator

Hi @hubutui,
Thank you for reporting the issue. If you would like to contribute to DALI please create a PR or we can do it as well.

@hubutui
Copy link
Author

hubutui commented Aug 4, 2024

Thanks, I think you could do it.

@hubutui hubutui closed this as completed Aug 4, 2024
mdabek-nvidia added a commit to mdabek-nvidia/DALI that referenced this issue Aug 5, 2024
Fix to: NVIDIA#5591

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
mdabek-nvidia added a commit that referenced this issue Aug 5, 2024
Fix to: #5591

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@mdabek-nvidia
Copy link
Collaborator

Thank you @hubutui, the fix is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants