Increase timeout, parametrize Python version in Jupyter tests #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanuszL
changed the title
ptrendx
approved these changes
Aug 20, 2018
|
I added python version selection for the second jupyter test. Please merge if you approve this so we can close internal QA reported issues. Tested 34030. |
qa/L1_jupyter_plugins/test.sh
Outdated
| --ExecutePreprocessor.kernel_name=python2 \ | ||
| --ExecutePreprocessor.timeout=300 \ | ||
| --ExecutePreprocessor.kernel_name=python${PYVER:0:1} \ | ||
| --ExecutePreprocessor.timeout=600 \ | ||
| --output output.ipynb {} | ||
| find */* -name "main.py" | xargs -i python2 {} -t |
There was a problem hiding this comment.
python2 in this line as well?
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
drivanov
pushed a commit
to drivanov/DALI
that referenced
this pull request
Sep 4, 2018
…#126) Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> Signed-off-by: Andrei <andreii@nvidia.com>
drivanov
pushed a commit
to drivanov/DALI
that referenced
this pull request
Sep 4, 2018
…#126) Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> Signed-off-by: Andrei <andreii@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com