Filtering extensions that FieReader can read #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ptredak <ptredak@nvidia.com>
JanuszL
requested changes
Aug 24, 2018
Signed-off-by: ptredak <ptredak@nvidia.com>
|
Done. |
JanuszL
reviewed
Aug 25, 2018
| for (const std::string& s : valid_extensions) { | ||
| size_t pos = full_path.rfind(s); | ||
| if (pos != std::string::npos && pos + s.size() == full_path.size()) { | ||
| file_label_pairs->push_back(std::make_pair(full_path, label)); |
There was a problem hiding this comment.
Now lower case path is added to list, but FS is case sensitive and if there is any uppercase in the real path it would fail opening it.
There was a problem hiding this comment.
Facepalm. Yup, I will change that on Monday.
Signed-off-by: ptredak <ptredak@nvidia.com>
JanuszL
approved these changes
Aug 28, 2018
drivanov
pushed a commit
to drivanov/DALI
that referenced
this pull request
Sep 4, 2018
* Filtering extensions that FieReader can read Signed-off-by: ptredak <ptredak@nvidia.com> * Make filtering case insensitive Signed-off-by: ptredak <ptredak@nvidia.com> * Change copy of full path to lowercase Signed-off-by: ptredak <ptredak@nvidia.com> Signed-off-by: Andrei <andreii@nvidia.com>
drivanov
pushed a commit
to drivanov/DALI
that referenced
this pull request
Sep 4, 2018
* Filtering extensions that FieReader can read Signed-off-by: ptredak <ptredak@nvidia.com> * Make filtering case insensitive Signed-off-by: ptredak <ptredak@nvidia.com> * Change copy of full path to lowercase Signed-off-by: ptredak <ptredak@nvidia.com> Signed-off-by: Andrei <andreii@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ptredak ptredak@nvidia.com