Use epoch_size instead of hardcoded values #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
ptrendx
reviewed
Sep 19, 2018
| pipes = [pipe_name(batch_size=BATCH_SIZE, num_threads=4, device_id = n, num_gpus = N, data_paths = data_set) for n in range(N)] | ||
| [pipe.build() for pipe in pipes] | ||
|
|
||
| iters = pipes[0].epoch_size("Reader") |
There was a problem hiding this comment.
Can we here check whether all of the iterators report the same size?
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
ptrendx
approved these changes
Sep 20, 2018
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
Works on 35845. |
pribalta
pushed a commit
to pribalta/DALI
that referenced
this pull request
Oct 1, 2018
* Use epoch_size instead of hardcoded values Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> * Add check iterators size equality for data container test Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> * Fix data container test Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com