Fix parsing of JPEG headers #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pribalta
approved these changes
Sep 18, 2018
JanuszL
changed the title
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
changed the title
|
Built and tested 697279. |
|
What is the reason of this fix? |
|
In ImageNet we have images which are not handled properly by the host decoder, like there are lacking 'JFIF' string in the header and etc. This patch also add host decoder to our data set tests. |
ptrendx
reviewed
Sep 19, 2018
dali/image/jpeg.cc
Outdated
| // Slightly modified from https://github.com/apache/incubator-mxnet/blob/master/plugin/opencv/cv_api.cc | ||
| // http://www.64lines.com/jpeg-width-height | ||
| // Gets the JPEG size from the array of data passed to the function, file reference: http://www.obrador.com/essentialjpeg/headerinfo.htm | ||
| // Based on https://github.com/scardine/image_size |
There was a problem hiding this comment.
The code seems only very slightly modified from the previous version, so I would put both references here (image_size and mxnet)
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
szalpal
approved these changes
Sep 20, 2018
ptrendx
approved these changes
Sep 20, 2018
pribalta
pushed a commit
to pribalta/DALI
that referenced
this pull request
Oct 1, 2018
* Fix parsing of JPEG headers for host decoder, add more tests Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com> * Update comment for jpeg.cc code inspiration Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com