Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting build dirs #189

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conflicting build dirs #189

merged 2 commits into from
Sep 28, 2018

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Sep 27, 2018

No description provided.

@szalpal szalpal requested a review from JanuszL September 27, 2018 15:05
@JanuszL
Copy link
Contributor

JanuszL commented Sep 28, 2018

Builds 36260.

@JanuszL
Copy link
Contributor

JanuszL commented Sep 28, 2018

Lint failed, you nee to update qa/L0_lint/test.sh as it assumes that build is in the build directory.

JanuszL
JanuszL requested changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@JanuszL JanuszL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint test.

@szalpal
Copy link
Member Author

szalpal commented Sep 28, 2018 •
edited
Loading

Building 36264

@szalpal
DALI-218 Resolving build dirs conflict
0c426b5 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
QA script error fix
d390828 
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@JanuszL JanuszL merged commit e247f9c into NVIDIA:master Sep 28, 2018
pribalta pushed a commit to pribalta/DALI that referenced this pull request Oct 1, 2018
@szalpal @pribalta
Conflicting build dirs (NVIDIA#189)
57880a1 
* DALI-218 Resolving build dirs conflict

Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>

* QA script error fix

Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal szalpal deleted the conflicting_build_dirs branch January 22, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@ptrendx ptrendx Awaiting requested review from ptrendx

@cliffwoolley cliffwoolley Awaiting requested review from cliffwoolley

@klecki klecki Awaiting requested review from klecki

@pribalta pribalta Awaiting requested review from pribalta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szalpal @JanuszL