Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cast and CoinFlip GPU benchmarks #3541

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Add Cast and CoinFlip GPU benchmarks #3541

merged 4 commits into from
Dec 2, 2021

Conversation

szkarpinski
Copy link
Collaborator

@szkarpinski szkarpinski commented Nov 29, 2021 •
edited
Loading

Signed-off-by: Szymon Karpiński hugo@staszic.waw.pl

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

This PR adds GPU benchmarks for Cast and CoinFlip operators.

Additional information

  • Affected modules and functionalities: just two benchmark files added together with appropriate CMake entries.

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@szkarpinski
Add Cast and CoinFlip GPU benchmarks
85e1621 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szkarpinski
Fix code formatting
b77b857 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@szkarpinski
Remove namespace indent
0183f74 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
klecki
klecki approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@klecki klecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a comment, you may want to look into coin_flip as it's typically used: that is, with no inputs and returning a scalar in each sample. Probably it's fast enough, but it might be worth to check.

@klecki
Copy link
Contributor

klecki commented Nov 30, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3501194]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3501194]: BUILD FAILED

@klecki
Copy link
Contributor

klecki commented Dec 1, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3507259]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3507259]: BUILD PASSED

@klecki klecki merged commit 0827d29 into NVIDIA:main Dec 2, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
1f0ea0d 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
aa9381f 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
5c34cf3 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
6ee6d35 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
1d5e960 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
a0672d4 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
53cd307 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
7750d91 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
301ad80 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
76712aa 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
bf43751 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
3b1d086 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
25d3976 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
2d84283 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
@JanuszL JanuszL mentioned this pull request Mar 30, 2022
Closed
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
0f3c753 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@szkarpinski @cyyever
Add Cast and CoinFlip GPU benchmarks (NVIDIA#3541)
f3fd7ea 
Signed-off-by: Szymon Karpiński <hugo@staszic.waw.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantonguirao jantonguirao jantonguirao approved these changes

@klecki klecki klecki approved these changes

Assignees

@jantonguirao jantonguirao

@klecki klecki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szkarpinski @klecki @dali-automaton @jantonguirao