Quantize GDS chunk size to 1 MB. #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
jantonguirao
approved these changes
Mar 24, 2022
| size_t chunk_size = static_cast<size_t>( \ | ||
| div_ceil(static_cast<uint64_t>(curr_tensor_list.nbytes()), | ||
| static_cast<uint64_t>(thread_pool_.NumThreads()))); | ||
| const size_t kGDSChunkGranularity = 1<<20; |
There was a problem hiding this comment.
Suggested change
| const size_t kGDSChunkGranularity = 1<<20; | |
| const size_t kGDSChunkGranularity = 1<<20; // 1 MB |
|
CI MESSAGE: [4225357]: BUILD STARTED |
|
CI MESSAGE: [4225357]: BUILD PASSED |
JanuszL
approved these changes
Mar 25, 2022
mzient
changed the title
Closed
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
May 13, 2022
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
cyyever
pushed a commit
to cyyever/DALI
that referenced
this pull request
Jun 7, 2022
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Category:
Other Optimization
Description:
Previously, the chunks were just evenly distributed among threads in ThreadPool. This change introduces a granularity, which prevents splitting of small chunks and guarantees alignment of all but the last chunk in the sample.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Checklist
Tests
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A