Extend and relax TensorList sample APIs #4358
Merged
+144
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ResizeSample that allows to resize individual samples. Automatically converts the batch into non-contiguous mode, same as SetSample. SetSample no longer requires the order between the batch and new sample to match - instead it waits for the incoming order in the order of current batch, so the access in the batch order will be correct. Fix a problem that prohibited copying from empty batch that had no samples nor type set. Now it resets the current batch to similar state. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6183827]: BUILD STARTED |
|
CI MESSAGE: [6183827]: BUILD PASSED |
mzient
reviewed
Oct 17, 2022
| // Bounds check | ||
| assert(sample_idx >= 0 && sample_idx < curr_num_tensors_); | ||
| // Resizing any individual sample converts the batch to non-contiguous mode | ||
| MakeNoncontiguous(); |
There was a problem hiding this comment.
Suggested change
| MakeNoncontiguous(); | |
| if (volume[new_shape] != volume[shape_.set_tensor_shape(sample_idx)]) | |
| MakeNoncontiguous(); |
?
There was a problem hiding this comment.
As discussed on slack, I think if we want to have a variant that doesn't break the contiguity, it should be a separate call like ReshapeSample or ResizeSample with some parameter, that would always enforce that we have a valid volume. That way the bahaviour is consistent and we know the postconditions of the call always.
mzient
approved these changes
Oct 17, 2022
stiepan
reviewed
Oct 18, 2022
stiepan
reviewed
Oct 18, 2022
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
stiepan
approved these changes
Oct 18, 2022
|
!build |
|
CI MESSAGE: [6216588]: BUILD STARTED |
|
CI MESSAGE: [6216588]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: New feature, Bug fix
Description:
Add ResizeSample that allows to resize individual samples. Automatically converts the batch into non-contiguous mode, same as SetSample.
SetSample no longer requires the order between the batch and new sample to match - instead it waits for the incoming order in the order of current batch, so the access in the batch order will be correct.
Fix a problem that prohibited copying from empty batch that had no samples nor type set. Now it resets the current batch to similar state.
Those features are useful for implementing the Split and Merge operators.
Additional information:
Affected modules and functionalities:
TensorList
Key points relevant for the review:
If the parameters to order::wait are in correct order.
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A