Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New thread pool #4635

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[WIP] New thread pool #4635

wants to merge 15 commits into from

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Feb 2, 2023

DO NOT REVIEW

I've pushed it to run an experiment that verifies a hypothesis that we never destroy a ThreadPool with outstanding work in it.

Category:

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7183171]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7183171]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7189340]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7189340]: BUILD PASSED

@mzient mzient force-pushed the NewThreadPool branch 5 times, most recently from f0d76a6 to d74ec03 Compare February 9, 2023 12:49
@mzient mzient force-pushed the NewThreadPool branch 2 times, most recently from a181cde to 70deb50 Compare February 27, 2023 12:55
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mzient and others added 14 commits August 24, 2023 15:10
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
… a job object, reexposing the legacy thread pool interface.

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants