Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for automatic augmentations with EfficientNet example and CI #4695

Closed
wants to merge 2 commits into from

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Mar 7, 2023

Just the two PRs: #4648 and #4678 merged together for CI testing.

Category: Other

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

stiepan and others added 2 commits March 7, 2023 11:11
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Rename the selection operator

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Use random.uniform discrete mode

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Pass kwargs directly

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Assure uniform choice of manitudes in TA

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

AutoAugment: coallsce pollicies

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Avoid unnecessary casts in color operations expressed in terms of arithm ops

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

AutoContrast, one less float32 intermediate result

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Expose select operator

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Review rework, usage lessons learnt from the expiriments

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Adjust the docs

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Better handling of non-unique names, better custom kwargs handling, improved error messaging

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Rework pretty_select and utils

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Linter complaints

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Private modules

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Simplify docs, simplify code

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Move policy to separate module

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

More (and more intelegible) docs

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Type annotations

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Improved error reporting for as_param

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

More specific callable annotations

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Polish names

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Better error messaging, polishing

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Better error-reporting, warnings, default random_sign

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Make Aug private

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Wrapper tests

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

More tests

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

More tests

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Test select

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

More tests

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>

Shape passing fix

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Delete unused files from the example

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Keep only one EfficientNet layout

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Propagate defaults for EfficientNet training from yml to main.py

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Add implementation for DALI AA and TA with readme

Adjust some configuration options to accomodate it.
Remove the obsolete pipeline

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Add L3 test with benchmarks

The test run 1 less epoch than the readme to make it a bit shorter

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7507294]: BUILD STARTED

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7507294]: BUILD FAILED

@klecki klecki closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants