[AA] Add select operator/wrapper #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiepan
added
the
automatic augmentations
klecki
added
the
conditional execution
klecki
approved these changes
Mar 8, 2023
Comment on lines
+30
to
+35
| def sample_info(cb): | ||
|
|
||
| def idx_in_batch_cb(sample_info): | ||
| return np.array(cb(sample_info), dtype=np.int32) | ||
|
|
||
| return fn.external_source(idx_in_batch_cb, batch=False) |
There was a problem hiding this comment.
It would be nice to have the op for that at some point. Just a general, unrelated comment.
awolant
approved these changes
Mar 9, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
stiepan
force-pushed
the
auto_aug_select_util
branch
from
25276e4 to
d2a3e29
Compare
|
!build |
|
CI MESSAGE: [7531110]: BUILD STARTED |
|
CI MESSAGE: [7531110]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [7537860]: BUILD STARTED |
|
CI MESSAGE: [7537860]: BUILD FAILED |
|
CI MESSAGE: [7537860]: BUILD PASSED |
18 tasks
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
Adds
selectutility - meant to be used internally by automatic augmentation schemes. The meaning isselect(ops, op_idx, *args, **kwargs) = ops[op_idx](*args, **kwargs). It uses conditional execution for that.Additional information:
Part of AA lib: #4648
It loosely depends on the #4694 (it uses the wrapper for type annotation and testing).
Affected modules and functionalities:
Autograph integration with dali - so that it converts the auto_aug module too.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3230