Change WDS index version representation to integer. #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
!build |
JanuszL
reviewed
Mar 13, 2023
|
CI MESSAGE: [7567149]: BUILD STARTED |
JanuszL
reviewed
Mar 13, 2023
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
wds_version_integer
branch
from
9109e08
to
4f7370a
Compare
JanuszL
reviewed
Mar 13, 2023
JanuszL
reviewed
Mar 13, 2023
JanuszL
reviewed
Mar 13, 2023
JanuszL
reviewed
Mar 13, 2023
JanuszL
reviewed
Mar 13, 2023
| @@ -24,6 +24,7 @@ | |||
| #include <utility> | |||
| #include <vector> | |||
| #include "dali/core/bitmask.h" | |||
| #include "dali/core/version_util.h" | |||
There was a problem hiding this comment.
Why not include that in .cc file?
JanuszL
approved these changes
Mar 13, 2023
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
wds_version_integer
branch
from
1f1f3fc
to
1303849
Compare
JanuszL
approved these changes
Mar 13, 2023
|
CI MESSAGE: [7567523]: BUILD STARTED |
|
CI MESSAGE: [7567523]: BUILD PASSED |
mzient
commented
Mar 14, 2023
| #ifndef DALI_CORE_VERSION_UTIL_H_ | ||
| #define DALI_CORE_VERSION_UTIL_H_ | ||
|
|
||
| namespace dali { |
There was a problem hiding this comment.
The contents of this file are (mostly) copied from core/util.h - these functions are not generic enough to warrant a place in util.h. The differences:
GetVersionNumberrenamed toMakeVersionNumber- Added a default value for
patch - Made
valuea templateV *instead of fixedint *. - Added a customizable
invalid_value
jantonguirao
approved these changes
Mar 14, 2023
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
… utilties. (NVIDIA#4708) * Change WDS index version representation to integer. * Use a common utility for generating an integer version number. * Move version utilities to a standalone header * Make version utilities more generic Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
It changes the representation of the WDS index from a string to integer. It improves performance and it would help with comparisons.
Additional information:
Affected modules and functionalities:
WDS reader
Key points relevant for the review:
Tests:
dali/test/python/reader/test_webdataset_*.pyChecklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2557