Add equalize CPU variant #4742
Merged
Add equalize CPU variant #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
approved these changes
Mar 24, 2023
| for (int sample_idx = 0; sample_idx < num_samples; sample_idx++) { | ||
| tp.AddWork([this, sample_idx, &in_view, &out_view](int) { | ||
| RunSample(in_view, out_view, sample_idx); | ||
| }); |
There was a problem hiding this comment.
use num_elements() of each sample as priority for the task, so that the larger samples are executed first (better thread utilization)
Comment on lines
77
to
78
| void RunSample(TensorListView<StorageCPU, const uint8_t, ndim> &in_view, | ||
| TensorListView<StorageCPU, uint8_t, ndim> &out_view, int sample_idx) { |
There was a problem hiding this comment.
nitpick: Accept TensorView's instead of TLV, and get rid of sample_idx argument.
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
banasraf
approved these changes
Mar 27, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
stiepan
force-pushed
the
equalize_cpu_op
branch
from
3054898
to
0a71003
Compare
|
!build |
|
CI MESSAGE: [7724818]: BUILD STARTED |
|
CI MESSAGE: [7724818]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
The PR adds CPU variant for
fn.experimental.equalizeoperator. It simply wraps opencv call to cv::equalizeHist.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3264