Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps: pybind, FFmpeg, zstd #4749

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Update deps: pybind, FFmpeg, zstd #4749

merged 5 commits into from
Mar 31, 2023

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Mar 27, 2023 •
edited
Loading

Category: Other

Description:

Update deps. Initialize submodules recursively.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@klecki
Copy link
Contributor Author

klecki commented Mar 27, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7727957]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7727957]: BUILD FAILED

@klecki
Copy link
Contributor Author

klecki commented Mar 28, 2023

:works on my machine:

@klecki
Copy link
Contributor Author

klecki commented Mar 28, 2023

There is issue with CUTLASS 3.0 reported here: pytorch/pytorch#94188
which is related to using half intrinsics for targets that do not support them. Reverting the update until proper guards are added.

klecki added 2 commits March 28, 2023 17:48
@klecki
Update deps
9e9f361 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Adjust readme
9e2c113 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki klecki force-pushed the deps-update-2023-03 branch from 86dfede to 9e2c113 Compare March 28, 2023 15:50
@klecki klecki marked this pull request as ready for review March 28, 2023 16:29
@klecki
Copy link
Contributor Author

klecki commented Mar 28, 2023

Will be updated with NVIDIA/DALI_deps#79

@JanuszL JanuszL assigned JanuszL and unassigned mzient Mar 29, 2023
@klecki
If submodule, use --init
fc8ba46 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750371]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750372]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750372]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750371]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750994]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750995]: BUILD STARTED

@klecki
I need more init
cdb1020 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750994]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7751485]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7751286]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7751321]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7750995]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7751485]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7762737]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7762738]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7762737]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7762738]: BUILD FAILED

@klecki
Update so versions
b8df5bb 
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7764985]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7764986]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7764986]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7764985]: BUILD PASSED

@klecki klecki changed the title Update deps Update deps: pybind, FFmpeg, zstd Mar 31, 2023
@klecki klecki merged commit d0e6ac1 into NVIDIA:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@mzient mzient mzient approved these changes

@szalpal szalpal szalpal approved these changes

Assignees

@szalpal szalpal

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klecki @dali-automaton @szalpal @mzient @JanuszL