-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add median blur operator #4950
Add median blur operator #4950
Conversation
!build |
CI MESSAGE: [9028939]: BUILD STARTED |
CI MESSAGE: [9028939]: BUILD FAILED |
dali/python/bundle-wheel.sh
Outdated
@@ -122,6 +122,8 @@ DEPS_LIST=( | |||
"${DEPS_PATH}/lib/libzstd.so.1" | |||
"${DEPS_PATH}/lib/libz.so.1" | |||
"${DEPS_PATH}/lib/libcfitsio.so.4" | |||
"lib/libcvcuda.so.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there is any symbol versioning in CV-CUDA? In the case of FFmpeg we append DALI_
prefix to symbols so they won't clash with the symbols from any other FFmpeg build.
I'm just afraid of what may happens when the user will do:
import nvidia.dali```
and I suspect that symbols from the first cvcuda are going to be used.
!build |
CI MESSAGE: [9039982]: BUILD STARTED |
CI MESSAGE: [9039982]: BUILD FAILED |
!build |
CI MESSAGE: [9060724]: BUILD STARTED |
CI MESSAGE: [9060724]: BUILD PASSED |
CI MESSAGE: [9071120]: BUILD STARTED |
CI MESSAGE: [9071120]: BUILD FAILED |
766e610
to
68fcd79
Compare
CI MESSAGE: [9099699]: BUILD STARTED |
CI MESSAGE: [9100969]: BUILD STARTED |
68fcd79
to
89caf2c
Compare
CI MESSAGE: [9099699]: BUILD FAILED |
CI MESSAGE: [9100969]: BUILD FAILED |
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
89caf2c
to
ca63b2f
Compare
!build |
CI MESSAGE: [9149266]: BUILD STARTED |
!build |
CI MESSAGE: [9150286]: BUILD STARTED |
2bc77bf
to
449348b
Compare
!build |
CI MESSAGE: [9150315]: BUILD STARTED |
dali/operators/image/CMakeLists.txt
Outdated
add_subdirectory(convolution) | ||
add_subdirectory(distortion) | ||
if (${BUILD_CVCUDA}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a CMake option? If so, shouldn't it be if (BUILD_CVCUDA)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be. Done
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
CI MESSAGE: [9149266]: BUILD FAILED |
!build |
CI MESSAGE: [9150739]: BUILD STARTED |
CI MESSAGE: [9150315]: BUILD PASSED |
CI MESSAGE: [9150739]: BUILD FAILED |
CI MESSAGE: [9150739]: BUILD PASSED |
Signed-off-by: Rafal Banas <rbanas@nvidia.com>
Category:
New feature
Description:
It adds a new operator. It's a proof of concept for using cv-cuda ops in DALI.
Additional information:
Affected modules and functionalities:
New operator was added. I also included small change to improve support for uint16 in DALI.
The operator is mostly a thin layer around the cv-cuda op.
There are two parts that require any logic:
Key points relevant for the review:
The operator
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3559