Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Optimize experimental video reader checkpointing tests #5309

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szkarpinski
Copy link
Collaborator

@szkarpinski szkarpinski commented Feb 5, 2024

Category:

Other - test optimization

Description:

The main cost for experimental video reader is building the index. In this PR I change checkpointing tests to use videos with keyframe interval = 1, added in NVIDIA/DALI_extra#128. This speeds up experimental video reader checkpointing tests ~10x.

Additional information:

Affected modules and functionalities:

Experimental video reader checkpointing tests

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant