Don't initialize NVML in ThreadPool when not setting affinity. #5472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [15060425]: BUILD STARTED |
|
CI MESSAGE: [15060425]: BUILD PASSED |
jantonguirao
approved these changes
May 16, 2024
awolant
approved these changes
May 16, 2024
| // only for the CPU pipeline | ||
| if (device_id != CPU_ONLY_DEVICE_ID) { | ||
| // We use NVML only for setting thread affinity | ||
| if (device_id != CPU_ONLY_DEVICE_ID && set_affinity) { |
There was a problem hiding this comment.
Maybe it would be good to add the ( ) to not depend on the readers knowledge of operator priority in C++?
There was a problem hiding this comment.
I don't think it's counterintuitive here (unlike with bitwise ops, which are a mess), so I'll spare the reader parsing parentheses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other Optimization
Description:
NVML initialization takes considerable time. This PR skips the NVML initialization in ThreadPool when not setting thread affinity (which is the only situation when we need NVML). This change enables small tests using ThreadPool to take much less time.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A