Video decoder in plugin #5477
Merged
Video decoder in plugin #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
…functions Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
stiepan
reviewed
Jun 4, 2024
| if (spec.HasArgument("end_frame")) { | ||
| end_frame_ = spec.GetArgument<int>("end_frame"); | ||
| } else { | ||
| DALI_FAIL("Not passing `end_frame` argument is not yet implemented."); |
There was a problem hiding this comment.
Nitpick, to get rid two negations from the sentence.
Suggested change
| DALI_FAIL("Not passing `end_frame` argument is not yet implemented."); | |
| DALI_FAIL("Currently, `end_frame` argument is required."); |
stiepan
reviewed
Jun 4, 2024
| yuv_to_rgb(pFrame, nPitch, reinterpret_cast<uint8_t *>(dpFrame), | ||
| sample.decoder_->GetWidth() * 3, sample.decoder_->GetWidth(), | ||
| sample.decoder_->GetHeight(), full_range, cuStream); | ||
| CUDA_CALL(cudaStreamSynchronize(cuStream)); |
There was a problem hiding this comment.
Why is this synchronization needed here?
There was a problem hiding this comment.
It was leftover from the more extended version where we might want to do some postprocessing here. Removed it for now, I will add it if needed later.
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
!build |
|
CI MESSAGE: [15614667]: BUILD STARTED |
jantonguirao
approved these changes
Jun 6, 2024
|
CI MESSAGE: [15614667]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [15620547]: BUILD STARTED |
stiepan
approved these changes
Jun 6, 2024
|
CI MESSAGE: [15620547]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [15650237]: BUILD STARTED |
|
CI MESSAGE: [15650237]: BUILD FAILED |
|
!build |
2 similar comments
|
!build |
|
!build |
|
CI MESSAGE: [15879104]: BUILD STARTED |
|
CI MESSAGE: [15879104]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
!build |
|
CI MESSAGE: [15887381]: BUILD STARTED |
|
CI MESSAGE: [15887381]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature
Description:
Adds video decoder based on the Video Codec SDK 12.0 and is distributed with
nvidia-dali-videopackage.Additional information:
This PR adds the basic minimal video decoder based on Video Codec SDK 12.0. It can decode h264 and h265 videos passed as encoded binary buffers. Can be used with external source operator as an input. There is one argument:
end_frame- it tells what is the index of a last frame that should be decoded.Affected modules and functionalities:
Video plugin, video plugin tests.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A