Pin numpy to <1.24 in TensorFlow examples #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [15934953]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [15935241]: BUILD STARTED |
|
CI MESSAGE: [15934953]: BUILD PASSED |
|
CI MESSAGE: [15935241]: BUILD PASSED |
jantonguirao
approved these changes
Jun 19, 2024
mzient
reviewed
Jun 24, 2024
| @@ -3,3 +3,4 @@ argparse-utils | |||
| absl-py | |||
| Pillow | |||
| PyYAML | |||
| numpy<1.24 | |||
There was a problem hiding this comment.
Why not <2? Also, the description of the PR says "pin to 1.24" whereas it actually pins it to less than 1.24. I suggest renaming the PR (and keeping the code changes).
There was a problem hiding this comment.
Updated the commit message.
mzient
approved these changes
Jun 24, 2024
JanuszL
changed the title
- due to a recent release of backward incompatible numpy 2.0 pin its version in the TensorFlow examples Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pin its version in the TensorFlow examples
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
pin its version in the TensorFlow examples
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A