Move checkpoint to IterationData. Remove ExecIterData. #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
commented
Jul 9, 2024
| @@ -74,8 +76,11 @@ class OperatorTraces { | |||
| struct IterationData { | |||
| int64_t iteration_index = 0; | |||
| OperatorTraces operator_traces; | |||
| std::shared_ptr<Checkpoint> checkpoint; | |||
There was a problem hiding this comment.
I used shared_ptr here because it allows Checkpoint to be only forward-declared. Using unique_ptr wouldn't be much more elegant and would require IterationData to be DLL_PUBLIC (meh) and a separate translation unit for the destructor (blah) or a unique_ptr with a custom deleter (blah).
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
move_checkpoint_to_iter_data
branch
from
809f95b to
717a327
Compare
|
CI MESSAGE: [16441482]: BUILD STARTED |
mzient
commented
Jul 9, 2024
| if (checkpointing_) { | ||
| id->checkpoint = std::make_shared<Checkpoint>(); |
There was a problem hiding this comment.
Is it a problem that checkpoint would be NULL when checkpointing_ == false?
There was a problem hiding this comment.
I don't think so, @stiepan ?
szkarpinski
approved these changes
Jul 9, 2024
|
CI MESSAGE: [16441482]: BUILD PASSED |
|
CI MESSAGE: [16445782]: BUILD STARTED |
|
CI MESSAGE: [16445782]: BUILD PASSED |
mdabek-nvidia
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Checkpoint was previously stored in an executor-specific structure. It can land directly in IterationData, which will enable it to be carried along the pipeline.
Additional information:
Affected modules and functionalities:
Workspace
Old executor
Checkpointing
Key points relevant for the review:
Tests:
Checkpointing tests (all of them).
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A