Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PropagateError as [[noreturn]] #5589

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jul 30, 2024

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

PropagateError function is never used with a NULL exception pointer - it always throws. This PR acknowledges that by requiring non-NULL exception pointer and marking the function as [[noreturn]], silencing warnings that occur when it's used at the end of a non-void function.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [17044654]: BUILD STARTED

@szalpal szalpal self-assigned this Jul 30, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [17044654]: BUILD PASSED

@mzient mzient merged commit 0824e7e into NVIDIA:main Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants