Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build for Python 3.9 #5649

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix conda build for Python 3.9 #5649

merged 1 commit into from
Sep 30, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 26, 2024

  • adds libprotobuf as a runtime dependency for DALI conda
    build as it makes sure that the right version of
    libasbseil is installed

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • adds protobuf as a runtime dependency for DALI conda
    build as it makes sure that the right version of
    libasbseil is installed

Additional information:

Affected modules and functionalities:

  • conda recipee

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • TL1_tensorflow_dataset_conda
    • TL1_self-test_conda
    • TL1_python-self-test_conda
    • TL0_python_self_test_TU
    • TL0_tensorflow_plugin_conda
    • TL0_plugin_manager
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft September 26, 2024 19:32
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18782789]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18782789]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18789461]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18821076]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18821076]: BUILD PASSED

@JanuszL JanuszL marked this pull request as ready for review September 30, 2024 07:13
- adds protobuf as a runtime dependency for DALI conda
  build as it makes sure that the right version of
  libasbseil is installed

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18876715]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18876715]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18876715]: BUILD PASSED

@JanuszL JanuszL merged commit cd080a6 into NVIDIA:main Sep 30, 2024
6 checks passed
@JanuszL JanuszL changed the title Fix conda build for Python3.9 Fix conda build for Python 3.9 Sep 30, 2024
@JanuszL JanuszL deleted the fix_conda_39 branch September 30, 2024 14:16
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18917122]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18917122]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [18917122]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants